Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/assembly manual #12

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Fix/assembly manual #12

merged 9 commits into from
Jun 19, 2024

Conversation

KuraZuzu
Copy link
Collaborator

@KuraZuzu KuraZuzu commented Jun 11, 2024

What does this implement/fix?

組み立てマニュアルの品質を向上。

Does this close any currently open issues?

Issue #11 をクローズします。

How has this been tested?

アールティ社内でレビューしました。

Any other comments?

Checklists

Copy link
Contributor

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

軽微な指摘あります 🙏

サーボモータ1本体の切り欠きに対し、円形サーボホーンの**2本の切り欠き**の位置が一致するように指で回転させてください。
サーボモータ1本体の切り欠きに対し、円形サーボホーンの**2本の切り欠け**の位置が一致するように指で回転させてください。

**青色のラインは切りかけの位置を明示的に図示したものなので、実際のサーボモータに描かれていません**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表記ゆれがあります。

  • 切りかけ
  • 切り欠け
  • 切り欠き

一般的な「切り欠き」に統一しましょう。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

切り欠きに統一しました。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改変後の単語にtypo

not use -> not used

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not usedに統一しました。

Copy link
Contributor

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

@KuraZuzu KuraZuzu merged commit 1731073 into main Jun 19, 2024
4 checks passed
@KuraZuzu KuraZuzu deleted the fix/assembly_manual branch September 2, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants